codecov-commenter commented on PR #28192: URL: https://github.com/apache/superset/pull/28192#issuecomment-2088652503
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/28192?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report Attention: Patch coverage is `57.87671%` with `123 lines` in your changes are missing coverage. Please review. > Project coverage is 67.30%. Comparing base [(`2e5f3ed`)](https://app.codecov.io/gh/apache/superset/commit/2e5f3ed85149951200645e00e79a543de9bec02f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`1a73645`)](https://app.codecov.io/gh/apache/superset/pull/28192?dropdown=coverage&src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). > Report is 17 commits behind head on master. | [Files](https://app.codecov.io/gh/apache/superset/pull/28192?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...set/commands/database/uploaders/columnar\_reader.py](https://app.codecov.io/gh/apache/superset/pull/28192?src=pr&el=tree&filepath=superset%2Fcommands%2Fdatabase%2Fuploaders%2Fcolumnar_reader.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvY29tbWFuZHMvZGF0YWJhc2UvdXBsb2FkZXJzL2NvbHVtbmFyX3JlYWRlci5weQ==) | 37.70% | [38 Missing :warning: ](https://app.codecov.io/gh/apache/superset/pull/28192?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [superset/databases/api.py](https://app.codecov.io/gh/apache/superset/pull/28192?src=pr&el=tree&filepath=superset%2Fdatabases%2Fapi.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | 43.85% | [32 Missing :warning: ](https://app.codecov.io/gh/apache/superset/pull/28192?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...d/src/features/databases/UploadDataModel/index.tsx](https://app.codecov.io/gh/apache/superset/pull/28192?src=pr&el=tree&filepath=superset-frontend%2Fsrc%2Ffeatures%2Fdatabases%2FUploadDataModel%2Findex.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZlYXR1cmVzL2RhdGFiYXNlcy9VcGxvYWREYXRhTW9kZWwvaW5kZXgudHN4) | 69.64% | [16 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/superset/pull/28192?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...perset/commands/database/uploaders/excel\_reader.py](https://app.codecov.io/gh/apache/superset/pull/28192?src=pr&el=tree&filepath=superset%2Fcommands%2Fdatabase%2Fuploaders%2Fexcel_reader.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvY29tbWFuZHMvZGF0YWJhc2UvdXBsb2FkZXJzL2V4Y2VsX3JlYWRlci5weQ==) | 36.84% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/superset/pull/28192?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [superset-frontend/src/features/home/RightMenu.tsx](https://app.codecov.io/gh/apache/superset/pull/28192?src=pr&el=tree&filepath=superset-frontend%2Fsrc%2Ffeatures%2Fhome%2FRightMenu.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZlYXR1cmVzL2hvbWUvUmlnaHRNZW51LnRzeA==) | 35.29% | [9 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/superset/pull/28192?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [superset/databases/schemas.py](https://app.codecov.io/gh/apache/superset/pull/28192?src=pr&el=tree&filepath=superset%2Fdatabases%2Fschemas.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvZGF0YWJhc2VzL3NjaGVtYXMucHk=) | 82.92% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/superset/pull/28192?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [superset/commands/database/uploaders/csv\_reader.py](https://app.codecov.io/gh/apache/superset/pull/28192?src=pr&el=tree&filepath=superset%2Fcommands%2Fdatabase%2Fuploaders%2Fcsv_reader.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvY29tbWFuZHMvZGF0YWJhc2UvdXBsb2FkZXJzL2Nzdl9yZWFkZXIucHk=) | 77.77% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/superset/pull/28192?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [superset-frontend/src/pages/DatabaseList/index.tsx](https://app.codecov.io/gh/apache/superset/pull/28192?src=pr&el=tree&filepath=superset-frontend%2Fsrc%2Fpages%2FDatabaseList%2Findex.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3BhZ2VzL0RhdGFiYXNlTGlzdC9pbmRleC50c3g=) | 33.33% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/superset/pull/28192?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | <details><summary>Additional details and impacted files</summary> ```diff @@ Coverage Diff @@ ## master #28192 +/- ## ========================================== + Coverage 60.49% 67.30% +6.80% ========================================== Files 1931 1933 +2 Lines 76241 76490 +249 Branches 8566 8558 -8 ========================================== + Hits 46122 51480 +5358 + Misses 28015 22915 -5100 + Partials 2104 2095 -9 ``` | [Flag](https://app.codecov.io/gh/apache/superset/pull/28192/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [hive](https://app.codecov.io/gh/apache/superset/pull/28192/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [postgres](https://app.codecov.io/gh/apache/superset/pull/28192/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `77.52% <56.94%> (?)` | | | [presto](https://app.codecov.io/gh/apache/superset/pull/28192/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [python](https://app.codecov.io/gh/apache/superset/pull/28192/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `77.61% <56.94%> (+14.12%)` | :arrow_up: | | [sqlite](https://app.codecov.io/gh/apache/superset/pull/28192/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `76.98% <56.94%> (?)` | | | [unit](https://app.codecov.io/gh/apache/superset/pull/28192/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. </details> [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/superset/pull/28192?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
