eschutho commented on code in PR #28192:
URL: https://github.com/apache/superset/pull/28192#discussion_r1589736679


##########
superset/databases/api.py:
##########
@@ -1524,11 +1539,61 @@ def import_(self) -> Response:
         command.run()
         return self.response(200, message="OK")
 
+    @expose("/csv_upload_metadata/", methods=("POST",))

Review Comment:
   @dpgaspar would it make this more restful perhaps to say `/csv_metadata` as 
the endpoint name, and in the process of creating (POST) csv_metadata, the 
upload action/portion is just an implementation detail? (same question pertains 
to all three upload endpoints)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Reply via email to