lscheibel opened a new issue, #28331:
URL: https://github.com/apache/superset/issues/28331

   ### Bug description
   
   As far as I can tell and from what I'm seeing in the frontend, strings send 
from the backend to the frontend that have been formatted with `humanize` are 
not localised and will always use english. There's a couple of places where 
these strings are used directly in the frontend but one of them comes from 
[`superset/models/helpers.py`](https://github.com/apache/superset/blob/e94360486e3db9488119f805f4c118ba5021754a/superset/models/helpers.py#L546)
 which is then used in the chart editor in 
[`superset-frontend/src/explore/components/ExploreChartHeader/index.jsx`](https://github.com/apache/superset/blob/e94360486e3db9488119f805f4c118ba5021754a/superset-frontend/src/explore/components/ExploreChartHeader/index.jsx#L201).
   
   ### How to reproduce the bug
   
   1. Change the superset language to something other than english.
   2. Edit an existing chart.
   3. Take a look at the header and the last-modified label.
   
   ### Screenshots/recordings
   
   
![image](https://github.com/apache/superset/assets/44374653/c6b853f9-3b51-4471-a7ab-aa5cc0159231)
   
![image](https://github.com/apache/superset/assets/44374653/0dcd4132-3c9a-4b57-a7e1-935330434346)
   
   
   ### Superset version
   
   master / latest-dev
   
   ### Python version
   
   3.9
   
   ### Node version
   
   18 or greater
   
   ### Browser
   
   Chrome
   
   ### Additional context
   
   I found [flask-humanize](https://github.com/vitalk/flask-humanize) which 
could be a solution. Although a question would be, how much Superset wants to 
rely on server-side localised strings. Especially considering that moment.js is 
already bundled which can achieve similar things in the frontend.
   
   For a PR would you rather see something that fixes the localisation problem 
in the backend or changes that would send the date string to the frontend, 
where they would be pretty-printed using moment?
   
   ### Checklist
   
   - [X] I have searched Superset docs and Slack and didn't find a solution to 
my problem.
   - [X] I have searched the GitHub issue tracker and didn't find a similar bug 
report.
   - [ ] I have checked Superset's logs for errors and if I found a relevant 
Python stacktrace, I included it here as text in the "additional context" 
section.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to