rusackas commented on issue #28331:
URL: https://github.com/apache/superset/issues/28331#issuecomment-2093379254
Personally, I think doing this in the front end makes more sense, but it's
probably debatable! That would make it easier to leverage in the myriad places
we'll want to do so going forward.
One thing that's awkward here is the fact that `moment.js` is no longer
maintained. At _some point_ we might want to migrate to `date-fns` or
whatever's cool/stable. To minimize the pain here, it might make sense to
centralize the logic here as either a utility function in the codebase utils
(`get_humanized_time({datetime, lang})` or perhaps a react component that
renders a `span` with the appropriate string.
As long as we adhere to the DRY principle and reduce/reuse/recycle logic so
it's scalable/maintainable, I'm open to whatever works :) I'll just ping
@michael-s-molina @dpgaspar @mistercrunch who might have different/additional
opinions on the matter.
Thank you for offering to contribute a PR around this!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
