soumitra-st commented on issue #13623: URL: https://github.com/apache/superset/issues/13623#issuecomment-2095184847
I work in StarTree and volunteer to help resolve the issue. Found why the `CREATE CHART` is disabled for Pinot: 1. Button is disabled [HERE](https://github.com/apache/superset/blob/master/superset-frontend/src/SqlLab/components/ExploreResultsButton/index.tsx#L40) if allows_subquery is not defined or false 2. For [PinotEngineSpec](https://github.com/apache/superset/blob/master/superset/db_engine_specs/pinot.py#L28) , allows_subqueries is false 3. [Features](https://github.com/apache/superset/blob/master/superset/db_engine_specs/README.md#features) table summarizes the capabilities of all db engines We have several Superset dashboards using Pinot in our dev and QA environments. Why does `CREATE CHART` depend on subquery support? Pinot supports subquery, join, etc., using the multi-stage query engine. We can enable this mode for all features depending on the subquery support. We can enable the multi-stage engine based on an engine configuration, and then the features requiring subqueries will only work in this mode, but the current mode will also be there. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
