nytai commented on code in PR #28349:
URL: https://github.com/apache/superset/pull/28349#discussion_r1590479111
##########
superset-frontend/src/pages/SavedQueryList/index.tsx:
##########
@@ -449,6 +453,12 @@ function SavedQueryList({
input: 'search',
operator: FilterOperator.AllText,
},
+ {
+ Header: t('Description'),
+ id: 'description',
+ key: 'description',
+ operator: FilterOperator.AllText,
Review Comment:
The search filter should already be checking the description column, so is
this really necessary?
##########
superset-frontend/src/pages/SavedQueryList/index.tsx:
##########
@@ -297,6 +297,10 @@ function SavedQueryList({
accessor: 'label',
Header: t('Name'),
},
+ {
+ accessor: 'description',
Review Comment:
What happens if there's a really long description?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
