mistercrunch opened a new pull request, #28378:
URL: https://github.com/apache/superset/pull/28378
This is a major issue that's been plaguing the backend for a long time.
Currently you can't simply run a simple `from superset import models` without
getting an error about the app context missing.
This DRAFT PR tries to evaluate what's getting in the way. So far I've
identified:
- app.config being referenced in module scope, this is mostly easy to fix
for common configuration, where we can rely on flask.current_app and avoid
module scope
- dynamic/configurable model: this seems to be the core issue, where say we
let people configure their EncryptedField's type
- some reliance on SecurityManager, and SecurityManager.user_model used as a
relationship, I think this can be worked around using sqlalchemy's
`relationship("use-a-string-reference")` call
- ???
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
