dpgaspar commented on code in PR #28378:
URL: https://github.com/apache/superset/pull/28378#discussion_r1593855641
##########
superset/models/core.py:
##########
@@ -1071,9 +1069,22 @@ def get_oauth2_config(self) -> OAuth2ClientConfig | None:
return self.db_engine_spec.get_oauth2_config()
-sqla.event.listen(Database, "after_insert",
security_manager.database_after_insert)
Review Comment:
Alternatively we can move these registrations into here:
https://github.com/apache/superset/blob/master/superset/initialization/__init__.py#L414
I'm personally not in favour of stuff happening at the root level of modules
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
