kgabryje commented on code in PR #28370:
URL: https://github.com/apache/superset/pull/28370#discussion_r1593660897
##########
superset-frontend/src/components/Chart/Chart.tsx:
##########
@@ -150,9 +153,16 @@ const MonospaceDiv = styled.div`
overflow-x: auto;
white-space: pre-wrap;
`;
+class Chart extends React.PureComponent<ChartProps, {}> {
+ static defaultProps = defaultProps;
+
+ renderStartTime: any;
Review Comment:
Where does `renderStartTime` come from? In the old version, we're only
reading it, but we don't assign any value to it. In your changes you put
`renderStartTime` in ChartProps, but also as class's field. I don't think it's
actually passed as a prop anywhere, and as a class field it's also only read,
not assigned.
So maybe we should just remove it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
