kgabryje commented on code in PR #28370:
URL: https://github.com/apache/superset/pull/28370#discussion_r1593794793
##########
superset-frontend/src/components/Chart/Chart.tsx:
##########
@@ -150,9 +153,16 @@ const MonospaceDiv = styled.div`
overflow-x: auto;
white-space: pre-wrap;
`;
+class Chart extends React.PureComponent<ChartProps, {}> {
+ static defaultProps = defaultProps;
+
+ renderStartTime: any;
Review Comment:
Yeah, unless I misunderstand something here, renderStartTime is always
undefined because we don’t set its value anywhere, so maybe we could remove it
from the code. @rusackas any objections?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
