rusackas commented on code in PR #28370:
URL: https://github.com/apache/superset/pull/28370#discussion_r1595603018
##########
superset-frontend/src/components/Chart/Chart.tsx:
##########
@@ -150,9 +153,16 @@ const MonospaceDiv = styled.div`
overflow-x: auto;
white-space: pre-wrap;
`;
+class Chart extends React.PureComponent<ChartProps, {}> {
+ static defaultProps = defaultProps;
+
+ renderStartTime: any;
Review Comment:
Well, if it's not wired up, that's an odd problem. It sure seems like it'd
be useful for logging, which seems to be its intent. There's one in
`ChartRenderer.jsx` that IS wired up, for reference. Maybe we don't need both
though?
It WAS set in the [original
commit](https://github.com/apache/superset/commit/5c02e3199b924cc8a45622e660096d6fdc8c5857),
actually. I haven't checked to see when its initialization was _removed_ but
clearly there wasn't much outcry.
I'd err on the side of more logging, not less. Maybe @eschutho would be
interested in taking more advantage of this insight :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
