goldjee commented on code in PR #28572:
URL: https://github.com/apache/superset/pull/28572#discussion_r1607898576
##########
superset/translations/ru/LC_MESSAGES/messages.json:
##########
@@ -5,5682 +5,6034 @@
"22": ["22"],
"": {
"domain": "superset",
- "plural_forms": "nplurals=3; plural=(n%10==1 && n%100!=11 ? 0 :
n%10>=2 && n%10<=4 && (n%100<12 || n%100>14) ? 1 : 2)",
+ "plural_forms": "nplurals=3; plural=(n%10==1 && n%100!=11 ? 0 :
n%10>=2 && n%10<=4 && (n%100<12 || n%100>14) ? 1 : 2);",
"lang": "ru"
},
- "The datasource is too large to query.": [
- "Источник данных слишком велик для запроса."
+ "\n This filter was inherited from the dashboard's
context.\n It won't be saved when saving the chart.\n
": [
+ "\n Фильтр был унаследован из контекста дашборда.\n
Он не будет сохранен при сохранении диаграммы.\n "
],
- "The database is under an unusual load.": [
- "Нетипично высокая загрузка базы данных"
+ "\n Error: %(text)s\n ": [
+ "\n Ошибка: %(text)s\n "
],
- "The database returned an unexpected error.": [
- "База данных вернула неожиданную ошибку"
+ " (excluded)": [" (исключено)"],
+ " Set the opacity to 0 if you do not want to override the color
specified in the GeoJSON": [
+ " Установите прозрачность 0, если вы не хотите переписывать цвет,
указанный в GeoJSON"
],
- "There is a syntax error in the SQL query. Perhaps there was a
misspelling or a typo.": [
- "В SQL-запросе имеется синтаксическая ошибка. Возможно, это
орфографическая ошибка или опечатка."
+ " a dashboard OR ": [" дашборд или "],
+ " a new one": [" новый"],
+ " expression which needs to adhere to the ": [
+ ", который должен придерживаться "
],
- "The column was deleted or renamed in the database.": [
- "Столбец был удален или переименован в базе данных."
+ " source code of Superset's sandboxed parser": [
+ " исходный код sandboxed парсера Superset"
],
- "The table was deleted or renamed in the database.": [
- "Таблица была удалена или переименована в базе данных."
+ " standard to ensure that the lexicographical ordering\n
coincides with the chronological ordering. If the\n
timestamp format does not adhere to the ISO 8601 standard\n
you will need to define an expression and type for\n
transforming the string into a date or timestamp. Note\n
currently time zones are not supported. If time is stored\n
in epoch format, put `epoch_s` or `epoch_ms`. If no pattern\n
is specified we fall back to using the optional defaults on a per\n
database/column name level via the extra parameter.": [
+ " стандарта для обеспечения того, чтобы лексикографический порядок
совпадал с хронологическим порядком. Если формат временной метки не
соответствует стандарту ISO 8601, вам нужно будет определить выражение и тип
для преобразования строки в дату или временную метку. В настоящее время часовые
пояса не поддерживаются. Если время хранится в формате эпохи, введите
\\`epoch_s\\` или \\`epoch_ms\\`. Если шаблон не указан, будут использованы
необязательные значения по умолчанию на уровне имен для каждой базы
данных/столбца с помощью дополнительного параме
тра."
],
- "One or more parameters specified in the query are missing.": [
- "Один или несколько параметров, указанных в запросе, отсутствуют"
+ " to add calculated columns": [" для добавления вычисляемых столбцов"],
+ " to add metrics": [" для добавления мер"],
+ " to edit or add columns and metrics.": [
+ " для редактирования или добавления столбцов и мер."
],
- "The hostname provided can't be resolved.": [
- "Не удалось обнаружить хост."
+ " to mark a column as a time column": [
+ ", чтобы пометить столбец как столбец даты/времени"
],
- "The port is closed.": ["Порт закрыт."],
- "The host might be down, and can't be reached on the provided port.": [
- "Хост возможно, отключен, и с ним невозможно связаться по заданному
порту."
+ " to open SQL Lab. From there you can save the query as a dataset.": [
+ " в SQL Lab. Там вы сможете сохранить запрос как датасет."
],
- "Superset encountered an error while running a command.": [
- "Суперсет столкнулся с ошибкой во время выполнения команды."
+ " to visualize your data.": [" для визуализации ваших данных."],
+ "!= (Is not equal)": ["!= (не равно)"],
+ "%(dialect)s cannot be used as a data source for security reasons.": [
+ "%(dialect)s не может использоваться в качестве источника данных по
соображениям безопасности"
],
- "Superset encountered an unexpected error.": [
- "Суперсет столкнулся с неожиданной ошибкой."
+ "%(message)s\nThis may be triggered by: \n%(issues)s": [
+ "%(message)s\nВозможные причины: \n%(issues)s"
],
- "The username provided when connecting to a database is not valid.": [
- "Имя пользователя, указанное при подключении к базе данных,
недействительно"
+ "%(name)s.csv": ["%(name)s.csv"],
+ "%(name)s.pdf": ["%(name)s.pdf"],
+ "%(object)s does not exist in this database.": [
+ "%(object)s не существует в этой базе данных"
],
- "The password provided when connecting to a database is not valid.": [
- "Неверный пароль для базы данных."
+ "%(other)s charts will appear here": [
+ "%(other)s диаграмм появятся здесь"
],
- "Either the username or the password is wrong.": [
- "Неверное имя пользователя или пароль"
+ "%(other)s dashboards will appear here": [
+ "%(other)s дашбордов появятся здесь"
],
- "Either the database is spelled incorrectly or does not exist.": [
- "Неверное или несуществующее имя базы данных."
+ "%(other)s recents will appear here": [
+ "%(other)s недавних появятся здесь"
],
- "The schema was deleted or renamed in the database.": [
- "Схема была удалена или переименована в базе данных."
+ "%(other)s saved queries will appear here": [
+ "%(other)s сохраненных запросов появятся здесь"
],
- "User doesn't have the proper permissions.": [
- "У пользователя нет надлежащего доступа."
+ "%(prefix)s %(title)s": ["%(prefix)s %(title)s"],
+ "%(report_type)s schedule frequency exceeding limit. Please configure a
schedule with a minimum interval of %(minimum_interval)d minutes per
execution.": [
+ ""
],
- "One or more parameters needed to configure a database are missing.": [
- "Один или несколько параметров, необходимых для настройки базы данных,
отсутствуют"
+ "%(rows)d rows returned": ["Получено строк: %(rows)d"],
+ "%(subtitle)s\nThis may be triggered by:\n %(issue)s": [
+ "%(subtitle)s\nВозможные причины:\n %(issue)s"
],
- "The submitted payload has the incorrect format.": [
- "Загруженные данные имеют некорректный формат."
+ "%(type)s File": ["Файл %(type)s"],
+ "%(validator)s was unable to check your query.\nPlease recheck your
query.\nException: %(ex)s": [
+ "%(validator)s не смог проверить ваш запрос.\nПожалуйста,
перепроверьте его вручную.\nОшибка: %(ex)s"
],
- "The submitted payload has the incorrect schema.": [
- "Загруженные данные имеют некорректную схему."
+ "%s Error": ["%s Ошибка"],
+ "%s PASSWORD": [""],
+ "%s SSH TUNNEL PASSWORD": [""],
+ "%s SSH TUNNEL PRIVATE KEY": [""],
+ "%s SSH TUNNEL PRIVATE KEY PASSWORD": [""],
Review Comment:
@artemonsh, thank you for the feedback!
Right, there are still quite a bunch of empty strings. Translating, I was
leaving particular string as is if:
* I haven't encountered it in the UI and wasn't sure about the context.
* The string could be a common term that shouldn't be translated.
* It looked like some low-level stuff that, when translated, could confuse
end user. For instance, I have intentionally left lines 81-84 that you have
mentioned. I haven't stumbled upon them in the UI and, given that they are
uppercase, I thought that I could break something if I provide a translation.
That was the case when someone among previous contributors has translated
"DELETE" string (or some other one like that) and was asked to leave it as is.
* I wasn't sure how to properly translate a string because I am not familiar
with related functionality and didn't want to mess up.
Sure there is a lot more work to do. At this point my goal was to provide at
least something I was confident with to improve user experience, not the full
localization. As the next step, I was planning to check specific chart
settings, fill the gaps there and straighten up the terminology used. But I
think it's better to deliver that in future PRs.
Regarding what word to use as "chart" term. I totally agree that's one of
the core terms and it should be picked very carefully. For reference, Ozhegov's
dictionary gives this definition to the term:
> ГРАФИК - диаграмма, изображающая при помощи кривых количественные
показатели движения, состояния чего-н.
> ГРАФИК is a diagram that depicts quantitative indicators of movement,
state of something **with curves**.
Diagram is described as follows:
> ДИАГРАММА - Графическое изображение соотношения каких-н. величин.
> ДИАГРАММА is a graphical representation of the relationship of some
quantities.
Come on, "Диаграмма" is just 3 characters longer than "График", but that's
much more suitable :)
Yeah, Power BI is very popular, it's my daily workhorse as well. Just
checked the naming in v2.126.927.0 (February 2024), and they used
"Визуализации" ("Visualizations") for visual elements of dashboards, which is
even longer.
<img width="235" alt="PBI"
src="https://github.com/apache/superset/assets/7242338/95ab8e32-648d-44c0-a703-018eda7172ab";>
Of course, trying to incorporate new naming into Superset, I have checked
that the word fits the UI space. Looked quite nice and I haven't seen any
elements that were broken on my 13'' laptop screen. Let me show you some
examples.
**"Charts" screen**
<img width="1440" alt="Charts"
src="https://github.com/apache/superset/assets/7242338/f92e9593-28fd-4496-a43b-96e12e43be61";>
**"Create chart" dialog**
<img width="1440" alt="Create chart"
src="https://github.com/apache/superset/assets/7242338/3ad6fae4-6f5a-4822-946d-e1fd82c32706";>
**Chart editor**
<img width="334" alt="Chart editor"
src="https://github.com/apache/superset/assets/7242338/8c3cd4ff-a9cb-4506-93ab-d7ea4e7fad2b";>
**Picking a chart in Dashboard editor**
<img width="373" alt="Dashboard editor"
src="https://github.com/apache/superset/assets/7242338/c100c108-ce0a-4ef2-9639-8b7a64d37fd8";>
If there are some other spots worth checking, please tell me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
