goldjee commented on PR #28572:
URL: https://github.com/apache/superset/pull/28572#issuecomment-2122101193
@artemonsh, thank you for the feedback!
Right, there are still quite a bunch of empty strings. Translating, I was
leaving particular string as is if:
* I haven't encountered it in the UI and wasn't sure about the context.
* The string could be a common term that shouldn't be translated.
* It looked like some low-level stuff that, when translated, could confuse
end user. For instance, I have intentionally left lines 81-84 that you have
mentioned. I haven't stumbled upon them in the UI and, given that they are
uppercase, I thought that I could break something if I provide a translation.
That was the case when someone among previous contributors has translated
"DELETE" string (or some other one like that) and was asked to leave it as is.
* I wasn't sure how to properly translate a string because I am not familiar
with related functionality and didn't want to mess up.
Sure there is a lot more work to do. At this point my goal was to provide at
least something I was confident with to improve user experience, not the full
localization. As the next step, I was planning to check specific chart
settings, fill the gaps there and straighten up the terminology used. But I
think it's better to deliver that in future PRs.
Regarding what word to use as "chart" term. I totally agree that's one of
the core terms and it should be picked very carefully. For reference, Ozhegov's
dictionary gives this definition to the term:
> ГРАФИК - диаграмма, изображающая при помощи кривых количественные
показатели движения, состояния чего-н.
> ГРАФИК is a diagram that depicts quantitative indicators of movement,
state of something **with curves**.
Diagram is described as follows:
> ДИАГРАММА - Графическое изображение соотношения каких-н. величин.
> ДИАГРАММА is a graphical representation of the relationship of some
quantities.
Come on, "Диаграмма" is just 3 characters longer than "График", but that's
much more suitable :)
Yeah, Power BI is very popular, it's my daily workhorse as well. Just
checked the naming in v2.126.927.0 (February 2024), and they used
"Визуализации" ("Visualizations") for visual elements of dashboards, which is
even longer.
<img width="235" alt="PBI"
src="https://github.com/apache/superset/assets/7242338/95ab8e32-648d-44c0-a703-018eda7172ab";>
Of course, trying to incorporate new naming into Superset, I have checked
that the word fits the UI space. Looked quite nice and I haven't seen any
elements that were broken on my 13'' laptop screen. Let me show you some
examples.
**"Charts" screen**
<img width="1440" alt="Charts"
src="https://github.com/apache/superset/assets/7242338/f92e9593-28fd-4496-a43b-96e12e43be61";>
**"Create chart" dialog**
<img width="1440" alt="Create chart"
src="https://github.com/apache/superset/assets/7242338/3ad6fae4-6f5a-4822-946d-e1fd82c32706";>
**Chart editor**
<img width="334" alt="Chart editor"
src="https://github.com/apache/superset/assets/7242338/8c3cd4ff-a9cb-4506-93ab-d7ea4e7fad2b";>
**Picking a chart in Dashboard editor**
<img width="373" alt="Dashboard editor"
src="https://github.com/apache/superset/assets/7242338/c100c108-ce0a-4ef2-9639-8b7a64d37fd8";>
If there are some other spots worth checking, please tell me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
