constantin-huetterer commented on code in PR #27456: URL: https://github.com/apache/superset/pull/27456#discussion_r1611351809
########## docs/docs/contributing/creating-viz-plugins.mdx: ########## @@ -35,7 +35,7 @@ version of the template that ships with the version of Superset you are using. T can be installed by doing the following: ```bash -npm i -g yo +npm i -g yo (If it is not working, use alternate command "npm i -g @superset-ui/generator-superset") Review Comment: In the current state, I believe running `npm i -g @superset-ui/generator-superset` should be the default command and line 39 - 41 should be removed, because the code in the superset repo seems to be behind of what is published on NPM. From my understanding, the following happens: ```js cd superset-frontend/packages/generator-superset // local source code of generator-superset that comes with the superset repo npm i // install the dependencies for the local code npm link // globally link the local package so that it can be used anywhere ``` This should work without having to install superset globally from npm via `npm i -g @superset-ui/generator-superset`. The problem seems to be that the local code in the Superset Repo is behind what is published on NPM. The repo code contains version 0.18.25 of the generator: https://github.com/apache/superset/blob/1573c101a71d6ade1f24ac89f99c4c0998b429c7/superset-frontend/packages/generator-superset/package.json#L2-L3 [According to NPM](https://www.npmjs.com/package/@superset-ui/generator-superset?activeTab=versions) this version is 3 years old and this is probably why id doesn't work with new builds of superset anymore. `npm i -g @superset-ui/generator-superset` on the other hand installs version 2.1.0 which then seems to work. However, at a quick glance I couldn't find where the current source code of the generator actually is. Can someone help out and tell me which code is published to https://www.npmjs.com/package/@superset-ui/generator-superset? 🙂 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
