mistercrunch commented on code in PR #28784:
URL: https://github.com/apache/superset/pull/28784#discussion_r1622818094
##########
superset-frontend/webpack.config.js:
##########
@@ -496,7 +496,7 @@ const config = {
'react/lib/ReactContext': true,
},
plugins,
- devtool: 'source-map',
+ devtool: isDevMode ? 'source-map' : false,
Review Comment:
read somewhere that turning off source maps in prod may help memory usage,
but also thinking it's better to not have source maps in prod as it's lighter
weight / more secure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
