mistercrunch commented on code in PR #28784:
URL: https://github.com/apache/superset/pull/28784#discussion_r1622820323
##########
docker-compose.yml:
##########
@@ -147,7 +149,11 @@ services:
disable: true
superset-node:
- image: node:18
+ build:
Review Comment:
This makes things a bit more DRY and in sync with the Dockerfile, main thing
is the base is set in docker for this, and there's a `frontend-mem-nag` script
that checks some assumption and raises message if docker conditions aren't set
properly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
