michael-s-molina commented on code in PR #28780:
URL: https://github.com/apache/superset/pull/28780#discussion_r1627799382
##########
superset-frontend/plugins/plugin-chart-echarts/src/Histogram/buildQuery.ts:
##########
@@ -25,8 +25,10 @@ export default function buildQuery(formData:
HistogramFormData) {
return buildQueryContext(formData, baseQueryObject => [
{
...baseQueryObject,
+ extras: { where: `${column} IS NOT NULL` },
Review Comment:
Given that `column` can only contain numeric values, we automatically
exclude `NULL` values from the result. This also aligns better with the limit
control.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
