michael-s-molina commented on code in PR #28780:
URL: https://github.com/apache/superset/pull/28780#discussion_r1627829364
##########
superset-frontend/plugins/plugin-chart-echarts/src/Histogram/buildQuery.ts:
##########
@@ -25,8 +25,10 @@ export default function buildQuery(formData:
HistogramFormData) {
return buildQueryContext(formData, baseQueryObject => [
{
...baseQueryObject,
+ extras: { where: `${column} IS NOT NULL` },
columns: [...groupby, column],
post_processing: [histogramOperator(formData, baseQueryObject)],
+ metrics: undefined,
Review Comment:
`metrics` by default is `[]` but we need it to be `undefined` to [avoid a
GROUP
BY](https://github.com/apache/superset/blob/a9cebe81ea8cd1ae56df05d5807baa8f05398cc5/superset/models/helpers.py#L1525).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
