kgabryje opened a new pull request, #29119:
URL: https://github.com/apache/superset/pull/29119

   ### SUMMARY
   In Mixed Series chart, when user sets "Stack" option to true for both 
queries, the series of the second query are stacked on top of the series of the 
first query. The reason for that is that both queries could have the same stack 
ids.
   This PR introduces `stackIdSuffix`, which adds `_a` and `_b` suffixes to 
stack ids of queries A and B to ensure that they're unique.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   In the screenshots - the bars represent the second query. Before, they were 
stacked on top of the series from 1st query.
   
   Before:
   
   <img width="1727" alt="image" 
src="https://github.com/apache/superset/assets/15073128/bc273c4d-89f4-4142-b8d0-14db324f27a0";>
   
   After:
   
   <img width="1725" alt="image" 
src="https://github.com/apache/superset/assets/15073128/e2e649e2-43fe-464e-9dff-064aa5f874a4";>
   
   ### TESTING INSTRUCTIONS
   1. Create Mixed Series chart
   2. Set Stack to true for both queries
   3. Make sure that the series of both queries are stacked separately
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to