villebro commented on code in PR #29119:
URL: https://github.com/apache/superset/pull/29119#discussion_r1632140462
##########
superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/transformers.ts:
##########
@@ -225,6 +227,9 @@ export function transformSeries(
} else if (stack && isTrend) {
stackId = getTimeCompareStackId(forecastSeries.type, timeCompare, name);
}
+ if (stackId && stackIdSuffix) {
+ stackId += stackIdSuffix;
Review Comment:
maybe a nit, but a cybersec person once said that you should always use `\n`
as the separator in composite keys in cases where it's unlikely to appear
naturally in the original keys. I'm not sure there's lots of collision risk
here, but just in case I'd probably use `\n` instead of `_`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
