rusackas commented on code in PR #29118:
URL: https://github.com/apache/superset/pull/29118#discussion_r1633696852
##########
superset-frontend/src/dashboard/components/PropertiesModal/PropertiesModal.test.jsx:
##########
@@ -53,26 +58,30 @@ fetchMock.get('glob:*/api/v1/dashboard/*', {
},
});
+const requiredProps = {
+ dashboardId: 1,
+ show: true,
+ addSuccessToast: () => {},
+};
+
+const setup = overrideProps =>
+ mount(
+ <Provider store={mockStore}>
+ <PropertiesModal {...requiredProps} {...overrideProps} />
+ </Provider>,
+ {
Review Comment:
Doesn't seem like a blocker, but instead of adding the wrappingComponent and
wrappingComponentProps, I think you can use `import { styledMount as mount }
from 'spec/helpers/theming';` at the top and get all that for free.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
