hainenber commented on code in PR #29118:
URL: https://github.com/apache/superset/pull/29118#discussion_r1638417601
##########
superset-frontend/src/dashboard/components/PropertiesModal/PropertiesModal.test.jsx:
##########
@@ -53,26 +58,30 @@ fetchMock.get('glob:*/api/v1/dashboard/*', {
},
});
+const requiredProps = {
+ dashboardId: 1,
+ show: true,
+ addSuccessToast: () => {},
+};
+
+const setup = overrideProps =>
+ mount(
+ <Provider store={mockStore}>
+ <PropertiesModal {...requiredProps} {...overrideProps} />
+ </Provider>,
+ {
Review Comment:
Thanks for the heads-up, I've refactored using your suggestion and it
luckily helped out with another
[concern](https://github.com/apache/superset/pull/29118#discussion_r1633915563)
raised by @justinpark :D
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
