cgivre commented on issue #6610: Add support to Apache Drill URL: https://github.com/apache/incubator-superset/pull/6610#issuecomment-485015355 Hi @villebro Thanks for responding! Basically, I added a function to the `db_engine_specs` file that replaces the file extension with `@@@`. Then I wrote another function in the `db_engine_specs` that removes it. What was happening was that Superset was working great with Drill when it was querying a database, but if something had a file, the dot for the file extension would mess up the URLs. My approach works, however, there were two places that I couldn't figure out how to call the database specific function in `db_engine_specs` so I just added the string replacement in the code. The two locations are: https://github.com/apache/incubator-superset/blob/ce3f9c30a925330763b394903d1a16ce6a90a495/superset/assets/src/SqlLab/components/SouthPane.jsx#L107 and https://github.com/apache/incubator-superset/blob/ce3f9c30a925330763b394903d1a16ce6a90a495/superset/assets/src/SqlLab/components/SqlEditorLeftBar.jsx#L64 As you can see, these are not python files. I couldn't figure out how to insert the Python function to clean up the table name. Another approach which I tried but couldn't figure out was to add a function in db_engine_specs to do all the URL transformations. Any assistance would be greatly appreciated, as I'd really like to get this integrated into Superset. Thanks!!
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
