cgivre commented on issue #6610: Add support to Apache Drill URL: https://github.com/apache/incubator-superset/pull/6610#issuecomment-485592449 Ok, @villebro, @coderfender Last question. I made the changes and now the unit test for javascript is breaking. Here is the error I'm getting: ``` FAIL spec/javascripts/components/TableSelector_spec.jsx (6.083s) ● TableSelector › changeTable › test 2 expect(received).toBe(expected) // Object.is equality Expected: "my_table" Received: "main.my_table" 200 | label: 'my_table', 201 | }); > 202 | expect(mockedProps.onTableChange.getCall(0).args[0]).toBe('my_table'); | ^ 203 | expect(mockedProps.onTableChange.getCall(0).args[1]).toBe('main'); 204 | }); 205 | }); at Object.toBe (spec/javascripts/components/TableSelector_spec.jsx:202:60)1 ``` I'm guessing that the issue is something silly with the file below, but I'm not really sure how to fix that. https://github.com/apache/incubator-superset/blob/81c2c896f1a2b4479ed8a4614e7268d606a66401/superset/assets/src/components/TableSelector.jsx#L173-L174
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
