goldjee commented on PR #29377:
URL: https://github.com/apache/superset/pull/29377#issuecomment-2206958438
I've reviewed the feedback and made some adjustments to the translation. You
can find the breakdown below.
> "% calculation" is translated as "Расчет долей" which means "Share
calculation". It seems like an odd translation for "% calculation". I would
expect something more literal like "% вычисление" or "Вычисление процентов".
Funnel Chart. I felt like that literal translation is way too... literal. My
thought process was that each segment of the funnel is some part of total. That
part is represented with percentage value. The key difference of the selector
values is not how we calculate percentages themselves, it's what we take as a
base to get the share from. That's why I have picked this adaptation.
> "2/98 percentiles" and "9/91 percentiles" are translated as "2/98
процентиль" and "9/91 процентиль". The word should be "перцентиль" not
"процентиль". Also, it should probably be plural "перцентили" since it refers
to a range.
IIRC, originally it was "2/98 перцентиль" (singular in Russian as well). I
haven't found this particular word in dictionaries (some people say these two
versions are equivalent). Changed it because the original one felt too closely
borrowed from the English counterpart and Russian Wikipedia page refers to this
term as "процентиль". Furthermore, "percent" in Russian is "процент" and there
is no apparent reason why would the child word should change its letter order.
> "Adaptive formatting" is translated as "Адаптивный" which just means
"Adaptive". A more complete translation might be "Адаптивное форматирование".
I think this one refers to datetime formatting dropdown. The suggested
translation is too long for the UI element and doesn't fit well into the
context.
> The translations for the singular, dual and plural forms of "1 option", "1
row", etc. need review. The different forms don't seem to match the numbers.
For example:
msgid "%s row"
msgid_plural "%s rows"
msgstr[0] "%s строка"
msgstr[1] "%s строки"
msgstr[2] "%s строк"
I'm not sure why the AI highlights this as a potential problem. These
strings look alright to me, both in Poedit and in the UI itself.
> "%s строка" is singular but should match 1 row. "%s строки" is dual but
should match 2-4 rows. And "%s строк" is plural but should match 5+ rows.
I think this one was picked for `msgid "Show"`. This translation is marked
as fuzzy and I haven't seen the text in the UI. It looks very incorrect and I
will fix it.
> "Bins" is translated as "в" which just means "in". I would expect
something like "Категории" or "Интервалы".
Good point, I've missed this fuzzy and some other strings for the histogram
chart as well. I tend to use more specialized term for this entity when it
comes to a histogram, "Бины". Will fix.
> "Bar" is translated as "Гистограмма" which means "Histogram". "Столбчатая
диаграмма" is a more direct translation of "Bar chart".
Quick search indicates that this one is used in legacy charts that are out
of scope of this PR.
```
#: superset-frontend/plugins/legacy-preset-chart-nvd3/src/Bar/index.js:39
#: superset-frontend/plugins/legacy-preset-chart-nvd3/src/DistBar/index.js:42
#:
superset-frontend/plugins/plugin-chart-echarts/src/MixedTimeseries/controlPanel.tsx:150
#:
superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/Regular/Bar/index.ts:82
#:
superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/Regular/Line/controlPanel.tsx:84
msgid "Bar"
msgstr "Гистограмма"
```
> "Cell bars" was removed in the English text but still exists in the
Russian translation as "Гистограммы в ячейках". This translation should be
removed.
I can't find this particular string in the file.
> "Change order of columns." and "Change order of rows." are translated as
imperatives ("Сменить порядок столбцов", "Сменить порядок строк") rather than
infinitives like the English text. I would suggest "Изменить порядок столбцов."
and "Изменить порядок строк." to match the English grammar.
That was exactly as how I have translated these strings. But I've noticed I
have forgot to remove commas at their ends. Update incoming :)
> "Child label position" is translated as "Положение метки дочернего
элемента" which is very literal. A shorter translation like "Расположение меток
листьев" might sound more natural.
Again, "Расположение меток листьев" was my version.
> "Choose already exists" and "Choose columns to read" have fuzzy
translations that don't match the English and need to be updated.
I agree that these ones should be updated, but they are related to
`superset-frontend/src/features/databases/UploadDataModel/index.tsx` which I
haven't touched yet.
> "Decrease" is translated as "Уменьшить" which means "Reduce". In the
context of a waterfall chart, a better translation might be "Падение" or
"Снижение".
Not sure why the AI has picked the old version of the translation, but I
have interpreted this as "Падение" and its counterpart as "Рост". It looks good
on waterfall charts.
> "Determined by..." is translated as "Определяет..." which means
"Determines..." rather than "Determined by...". The translation should be
adjusted to match the passive voice of the original, something like
"Определяется..."
Looks like this one is related to
`superset-frontend/src/explore/components/controls/ColorSchemeControl/index.tsx`,
that was out of scope. The current translation ("Цветовая схема определена
соответствующим дашбордом. Измените цветовую схему в свойствах дашборда.")
indeed uses passive voice.
> "Dimensions" has a translation "Измерения" which is correct, but the
accompanying description is translated a bit awkwardly. I would suggest
rephrasing it to sound more natural in Russian while preserving the meaning.
I think that the accompanying description could use some improvements
indeed, but it feels natural in its current state.
> "Display Name" is translated as "Отображаемое имя" which is correct.
However, "Display" on its own is translated as the same thing, which is
incorrect. "Display" in that context likely refers to the display/appearance of
something, so a word like "Отображение" would be more appropriate.
"Отображение" is how "Display" string is currently translated.
>"Display all" is marked as fuzzy and needs a proper translation. Something
like "Показать все" would work.
Will fix.
> "Layout type of graph" is translated as just "Формат графа" which means
"Graph format". A better translation might be "Способ отрисовки графа" to
convey the meaning of layout.
In my translation I've used "Формат графа" because of its brevity and placed
"Способ отрисовки графа" into the tooltip. Just tried the longer version and it
looked fine. I'll switch to the suggested variant.
> Similarly, "Layout type of tree" is translated as just "Внешний вид
дерева" which means "Tree appearance". A better translation could be "Способ
отрисовки дерева" to mean the layout method.
Agreed.
> "Line" in the context of a line chart is translated as "Линейный" which
means "Linear". A more appropriate translation for a line chart would be
"График".
Looks like that comment is related to a fuzzy string for
`superset-frontend/plugins/legacy-preset-chart-nvd3/src/NVD3Controls.tsx` which
was left out of the scope of this translation.
> "Line chart is used to visualize..." has an overly literal and clunky
translation. I would suggest rephrasing it to sound more natural in Russian
while preserving the meaning.
Yeah, I'll change that one.
> "Loading" and "Loading..." are both translated as "Загрузка", but
"Загрузка..." with the ellipsis might be more appropriate for the "Loading..."
case to match the English punctuation.
"Loading..." is currently translated as "Загрузка..."
> The translations for the "Main" string seem fuzzy/incomplete. "Main" was
translated as just "минимум" meaning "minimum", which doesn't seem right. This
may need a more thorough translation.
Missed that one. It's very tough though. There is no close short analog that
could describe a "main" value as a value of an indicator for current period.
Moreover, when I provide any translation for this string, no matter how short
it is, the table just breaks. The values in the corresponding column just
disappear. I'll provide the most basic viable translation "Значение" for this
string and mark it as fuzzy for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
