kgabryje opened a new pull request, #29525: URL: https://github.com/apache/superset/pull/29525
### SUMMARY PR https://github.com/apache/superset/pull/28312 introduced an issue in time comparison feature in Table viz plugin. This PR swaps `visibility` to `hidden` in time comparison controls, so that their values would not get removed from form data. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF Before: https://github.com/apache/superset/assets/15073128/51301a93-7f64-43bf-b27d-45b03d976ccd After: https://github.com/apache/superset/assets/15073128/3069cb02-89e9-4494-9153-b6516dd3c7dc ### TESTING INSTRUCTIONS 1. Create a table chart with time comparison 2. Change time comparison 3. Verify that time comparison columns are still present. ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
