justinpark opened a new pull request, #29607:
URL: https://github.com/apache/superset/pull/29607

   ### SUMMARY
   
   When the selected database in the SQL editor is removed from the selection, 
the current implementation shows an empty state screen, making it appear as if 
all data has been lost.
   This commit changes the behavior to display a deprecated state message when 
an SQL statement exists, clearly indicating the issue instead of showing an 
empty state screen.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   Before:
   
   
https://github.com/user-attachments/assets/9ad7376e-89a3-4c41-acf1-78ca80996b2c
   
   After:
   
   ![Screenshot 2024-07-16 at 11 43 20 
AM](https://github.com/user-attachments/assets/2e0c0c39-42b9-465b-8b56-9d6e1c544067)
   
   ### TESTING INSTRUCTIONS
   - create a sql lab with a statement
   - delete the database connection that is used in the above sql editor
   - check the message in the sql editor
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [x] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to