eschutho commented on code in PR #29607:
URL: https://github.com/apache/superset/pull/29607#discussion_r1680010525
##########
superset-frontend/src/SqlLab/components/SqlEditor/SqlEditor.test.tsx:
##########
@@ -160,13 +160,23 @@ describe('SqlEditor', () => {
});
it('does not render SqlEditor if no db selected', async () => {
- const queryEditor = initialState.sqlLab.queryEditors[1];
+ const queryEditor = initialState.sqlLab.queryEditors[2];
const { findByText } = setup({ ...mockedProps, queryEditor }, store);
expect(
await findByText('Select a database to write a query'),
).toBeInTheDocument();
});
+ it('renders db deprecated message', async () => {
+ const queryEditor = initialState.sqlLab.queryEditors[1];
+ const { findByText } = setup({ ...mockedProps, queryEditor }, store);
+ expect(
+ await findByText(
+ 'The selected database is currently deprecated and cannot be used',
Review Comment:
Another option perhaps "could not be reached"?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
