sadpandajoe commented on code in PR #29265:
URL: https://github.com/apache/superset/pull/29265#discussion_r1680184407
##########
superset-frontend/cypress-base/cypress/e2e/dashboard/drillby.test.ts:
##########
@@ -524,10 +524,141 @@ describe('Drill by modal', () => {
});
it('Bar Chart V2', () => {
- testEchart('echarts_timeseries_bar', 'Bar Chart V2', [
+ const vizType = 'echarts_timeseries_bar';
+ const chartName = 'Bar Chart V2';
+ const drillClickCoordinates = [
[70, 94],
- [362, 68],
- ]);
+ [362, 474],
Review Comment:
Yeah coordinates are always flakey in cypress as things can always add or
subtract to it. You could try writing a function where you can pass in what you
are looking for and then it'll generate an approximate window coordinate for
you. I have that in our repo and it's still flakey but i'm not adding prs to
make these updates as much
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
