jnturton commented on code in PR #27073:
URL: https://github.com/apache/superset/pull/27073#discussion_r1685315712


##########
superset/db_engine_specs/drill.py:
##########
@@ -117,3 +120,23 @@ def get_url_for_impersonation(
                 )
 
         return url
+
+    @classmethod
+    def fetch_data(
+        cls,
+        cursor: Any,
+        limit: int | None = None,
+    ) -> list[tuple[Any, ...]]:
+        """
+        Custom `fetch_data` for Drill.
+
+        When no rows are returned, Drill raises a `RuntimeError` with the 
message

Review Comment:
   @john-bodley we believe this is now fixed sqlalchemy-drill. That's certainly 
where it _should_ be fixed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to