kgabryje opened a new pull request, #29788:
URL: https://github.com/apache/superset/pull/29788

   ### SUMMARY
   We were importing a huge package `antd-with-locales` (over 4MB) just to pick 
1 locale for DatePicker from it.
   This PR removes that import and lazy loads just the required locale.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   Before:
   
   <img width="1710" alt="Screenshot 2024-07-31 at 15 48 00" 
src="https://github.com/user-attachments/assets/01565475-9374-4de7-8c38-ff8c215bfb9d";>
   
   After:
   
   <img width="1710" alt="Screenshot 2024-07-31 at 15 43 44" 
src="https://github.com/user-attachments/assets/9ada6fb9-6cc7-42f3-8ae6-66dd65279a1d";>
   
   
   ### TESTING INSTRUCTIONS
   1. Add a time filter to a dashboard
   2. Switch to "Custom frame"
   3. Open a date picker
   4. Should work like before
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to