rusackas commented on PR #29788: URL: https://github.com/apache/superset/pull/29788#issuecomment-2261170314
Loving these! Here are some suggestions (take 'em or leave 'em) that I came up with _totally on my own with no help_. Potential concerns: - There might be a brief moment where the component doesn't render while the locale is being loaded - Error handling for failed locale imports could be improved Suggestions for improvement: - Consider adding a loading state instead of returning null when datePickerLocale is null - Add error handling for the locale import promise to gracefully handle failed imports - Consider memoizing the effect dependency array to prevent unnecessary re-runs of the effect -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
