betodealmeida commented on code in PR #29840:
URL: https://github.com/apache/superset/pull/29840#discussion_r1715362702
##########
superset/databases/api.py:
##########
@@ -1159,7 +1159,7 @@ def select_star(
self.incr_stats("init", self.select_star.__name__)
try:
result = database.select_star(
- Table(table_name, schema_name),
+ Table(table_name, schema_name, database.get_default_catalog()),
Review Comment:
Yeah, but I I couldn't find any API calls to this endpoint — it seems like
we return this in the database request now, instead of calling `/select_star/`,
which is why I didn't change the code to pass a parameter. I think we should
keep this endpoint until the next major version and then get rid of it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
