betodealmeida commented on code in PR #29943:
URL: https://github.com/apache/superset/pull/29943#discussion_r1720300385
##########
superset/db_engine_specs/base.py:
##########
@@ -2160,29 +2161,63 @@ def get_impersonation_key(cls, user: User | None) ->
Any:
"""
return user.username if user else None
+ # list of JSON path to fields in `encrypted_extra` that should be masked
when the
+ # database is edited
+ # pylint: disable=invalid-name
+ encrypted_extra_sensitive_fields: list[str] = []
Review Comment:
Ah, good point about the default behavior. We could have the attribute in
the base class default to:
```python
["$"]
```
This way everything would be masked.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
