betodealmeida commented on code in PR #29943: URL: https://github.com/apache/superset/pull/29943#discussion_r1720300780
########## superset/db_engine_specs/base.py: ########## @@ -45,6 +45,7 @@ from flask import current_app, g, url_for from flask_appbuilder.security.sqla.models import User from flask_babel import gettext as __, lazy_gettext as _ +from jsonpath_ng import parse Review Comment: Another good point! I've had issues with JSONPath libraries in the past, wrapping them in a helper method will help in the future. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
