mistercrunch commented on code in PR #30017:
URL: https://github.com/apache/superset/pull/30017#discussion_r1731872450
##########
superset/migrations/versions/2024-08-13_15-29_a6b32d2d07b1_remove_sl_columns.py:
##########
@@ -34,9 +34,14 @@
def upgrade():
connection = op.get_bind()
- if connection.dialect.name != "sqlite":
- drop_fks_for_table("sl_columns")
- op.drop_table("sl_columns")
+
+ try:
+ if connection.dialect.name != "sqlite":
Review Comment:
also seems like the special handling for sqlite could be handled within
`drop_fks_for_table`. More generally would be great to have migrations that are
simpler / self-healing / free-of-engine-specific-logic through better utils.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
