sadpandajoe commented on code in PR #30017:
URL: https://github.com/apache/superset/pull/30017#discussion_r1731959288
##########
superset/migrations/versions/2024-08-13_15-27_e53fd48cc078_remove_sl_dataset_users.py:
##########
@@ -34,9 +34,14 @@
def upgrade():
connection = op.get_bind()
- if connection.dialect.name != "sqlite":
- drop_fks_for_table("sl_dataset_users")
- op.drop_table("sl_dataset_users")
+
+ try:
+ if connection.dialect.name != "sqlite":
+ drop_fks_for_table("sl_dataset_users")
+ op.drop_table("sl_dataset_users")
+ except sa.exc.NoSuchTableError:
Review Comment:
Even if we updated `drop_fks_for_table` we'd have to write something to drop
table too, else it'll fail won't it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
