geido commented on code in PR #29632:
URL: https://github.com/apache/superset/pull/29632#discussion_r1742216058
##########
superset-frontend/src/dashboard/containers/DashboardPage.tsx:
##########
@@ -192,7 +239,8 @@ export const DashboardPage: FC<PageProps> = ({ idOrSlug }:
PageProps) => {
}, [addDangerToast, datasets, datasetsApiError, dispatch]);
if (error) throw error; // caught in error boundary
- if (!readyToRender || !hasDashboardInfoInitiated) return <Loading />;
+
+ const isLoading = !dashboardInfo;
Review Comment:
Must decouple the data that is required to show the charts list from the
data required to show other parts of the Dashboard to enable progressive
rendering.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
