khtruong commented on a change in pull request #7391: feat: see Presto row and
array data types
URL:
https://github.com/apache/incubator-superset/pull/7391#discussion_r279120122
##########
File path: superset/db_engine_specs.py
##########
@@ -804,6 +809,21 @@ class PrestoEngineSpec(BaseEngineSpec):
date_add('day', 1, CAST({col} AS TIMESTAMP))))",
}
+ type_map = {
Review comment:
Ah yes. This is a mapping copied from the pyhive package (package we use for
most of our presto needs). It's basically a mapping of strings to SQL object
types defined by sqlalchemy. There isn't a tinyint data type defined by
sqlalchemy, which is why we use mysql. But I agree it seems leaky. I can create
a skeleton for tinyint and should create one for ROW object. From the looks of
it, it looks like we just use its string representation in our code base so far.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
