khtruong commented on a change in pull request #7391: feat: see Presto row and
array data types
URL:
https://github.com/apache/incubator-superset/pull/7391#discussion_r279607204
##########
File path: superset/db_engine_specs.py
##########
@@ -814,6 +834,164 @@ def get_view_names(cls, inspector, schema):
"""
return []
+ @classmethod
+ def _create_column_info(cls, column, name, data_type):
Review comment:
I was able to add type hints and returns for all new methods except for the
my_db parameter in the method select_star because it exposed a circular
dependency. I created issue
https://github.com/apache/incubator-superset/issues/7412 to address refactoring
for this file.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
