eschutho commented on code in PR #29898:
URL: https://github.com/apache/superset/pull/29898#discussion_r1769247280
##########
superset/charts/post_processing.py:
##########
@@ -186,6 +200,14 @@ def pivot_df( # pylint: disable=too-many-locals,
too-many-arguments, too-many-s
if apply_metrics_on_rows:
df = df.T
+ # replace the remaining temporary placeholder string for np.nan after
pivoting
+ df.replace("SUPERSET_PANDAS_NAN", np.nan, inplace=True)
+ df.rename(
+ index={"SUPERSET_PANDAS_NAN": np.nan},
+ columns={"SUPERSET_PANDAS_NAN": np.nan},
+ inplace=True,
+ )
+
Review Comment:
Converting the values back so that we don't print "SUPERSET_PANDAS_NAN"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
