betodealmeida commented on code in PR #29898:
URL: https://github.com/apache/superset/pull/29898#discussion_r1775416916
##########
superset/charts/post_processing.py:
##########
@@ -86,7 +87,8 @@ def pivot_df( # pylint: disable=too-many-locals,
too-many-arguments, too-many-s
# pivot data; we'll compute totals and subtotals later
if rows or columns:
# pivoting with null values will create an empty df
- df = df.fillna("NULL")
Review Comment:
@mistercrunch the problem here is that we do the pivot in Pandas (for
reports and CSV download), and it will fail if the dataframe has `NaN`s.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
