luizcapu opened a new pull request, #30379:
URL: https://github.com/apache/superset/pull/30379

   ### SUMMARY
   
   This PR addresses the issue https://github.com/apache/superset/issues/30377
   
   
   
   
   ### TESTING INSTRUCTIONS
   
   - Reproduce the steps described on the issue
   
   1. Go to the datasets page
   2. Pick any existing dataset name and prepare a payload as follows (example 
using the users datasets)
   ```
   {
     'table_name': 'users',
     'schema': 'other',
     'database_id': 1,
   }
   ```
   3. Submit this payload via a POST request to /api/v1/dataset/get_or_create
   4. The API behaviour now is as follows:
     - If it is for a new schema: creates the new dataset and return 200 with 
expected response body
     - If it is for the same schema: does not create the new dataset and return 
422 instead
   
   - Integration tests were also added for the new behaviour
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to