luizcapu commented on PR #30379: URL: https://github.com/apache/superset/pull/30379#issuecomment-2376472588
Marking this PR as ready for review. [test-sqlite](https://github.com/apache/superset/actions/runs/11019081178/job/30655002034?pr=30379) is the only test failing. However, it's failing with `sqlalchemy.exc.IntegrityError: (sqlite3.IntegrityError) UNIQUE constraint failed: tables.table_name`, which is inherently opposed to the nature of this PR. Furthermore, there are some signals that this constraint should be dropped: - it doesn't align with other databases (MySQL/Postgres) or with the overall Superset functionalities (as it does allow duplicate table_names for different databases/schemas) - The Github action logs says: `SQLite Database support for metadata databases will be removed in a future version of Superset.` - There's [this migration](https://github.com/apache/superset/blob/master/superset/migrations/versions/2020-09-25_10-56_18532d70ab98_fix_table_unique_constraint_in_mysql.py) that is removing the uniqueness constraint on the table_name, but is doing it for `MySQLDialect` only I could use some guidance to decide whether or not dropping this constraint is the right decision. And if so, how to do it. Thank you in advance. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
