villebro commented on PR #30716: URL: https://github.com/apache/superset/pull/30716#issuecomment-2448669384
@vedantprajapati17 I am unable to properly review this PR due to the following: - I'm unable to reproduce the issue without dedicating considerable time for this. For instance, the fact that the before/after payloads aren't diffable (one is JS, the other is JSON) doesn't help. - I still don't understand how `xaxis.type` changes as a consequence of this PR, despite there being no such change in the PR. Also, we would need a minimal unit test to validate that `reorderForecastSeries` works as expected. This both helps understand how the function works, and will help refactoring and protect against regressions going forward. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
