villebro commented on code in PR #30819:
URL: https://github.com/apache/superset/pull/30819#discussion_r1826284568
##########
superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/transformProps.ts:
##########
@@ -251,7 +252,7 @@ export default function transformProps(
legendState,
});
const seriesContexts = extractForecastSeriesContexts(
- Object.values(rawSeries).map(series => series.name as string),
+ rawSeries.map(series => series.name as string),
Review Comment:
I'm not sure why we were doing `Object.values` on an array, maybe a typo
##########
superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/transformProps.ts:
##########
@@ -251,7 +252,7 @@ export default function transformProps(
legendState,
});
const seriesContexts = extractForecastSeriesContexts(
- Object.values(rawSeries).map(series => series.name as string),
+ rawSeries.map(series => series.name as string),
Review Comment:
Bycatch: I'm not sure why we were doing `Object.values` on an array, maybe a
typo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
