villebro commented on code in PR #30819:
URL: https://github.com/apache/superset/pull/30819#discussion_r1826278703
##########
superset-frontend/plugins/plugin-chart-echarts/src/utils/series.ts:
##########
@@ -642,3 +646,22 @@ export function getTimeCompareStackId(
}) || defaultId
);
}
+
+const TOOLTIP_SERIES_KEY = 'seriesId';
+export function extractTooltipKeys(
+ forecastValue: any[],
+ yIndex: number,
+ richTooltip?: boolean,
+ tooltipSortByMetric?: boolean,
+): string[] {
+ if (richTooltip && tooltipSortByMetric) {
+ return forecastValue
+ .slice()
Review Comment:
Slicing to not mutate the input value (this would have caused issues in the
new tests)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
