cgivre commented on a change in pull request #6610: Add support to Apache Drill
URL:
https://github.com/apache/incubator-superset/pull/6610#discussion_r280123227
##########
File path: superset/assets/src/components/TableSelector.jsx
##########
@@ -170,13 +170,8 @@ export default class TableSelector extends
React.PureComponent {
this.setState({ tableName: '' });
return;
}
- const namePieces = tableOpt.value.split('.');
- let tableName = namePieces[0];
- let schemaName = this.props.schema;
- if (namePieces.length > 1) {
- schemaName = namePieces[0];
- tableName = namePieces[1];
- }
+ const tableName = tableOpt.value;
+ const schemaName = this.props.schema;
Review comment:
@villebro Thanks for your help. I would agree that the table
handling/splitting should happen on the backend, so that way custom parsing
(such as what I had to do for Drill) could all happen on in the backend.
@mistercrunch, does this complete the PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
