cgivre commented on a change in pull request #6610: Add support to Apache Drill
URL:
https://github.com/apache/incubator-superset/pull/6610#discussion_r283400438
##########
File path: superset/db_engine_specs.py
##########
@@ -721,6 +721,70 @@ def get_table_names(cls, inspector, schema):
return sorted(inspector.get_table_names())
+class DrillEngineSpec(BaseEngineSpec):
+ """Engine spec for Apache Drill"""
+ engine = 'drill'
Review comment:
@villebro
I'm going to wait until #7453 is committed. My experiments with your branch
basically solved all the issues with the Drill integration. Once that's done,
this PR will just be some mods to the `db_engine_specs.py` and hopefully will
be easy to commit as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
