rusackas commented on code in PR #30961:
URL: https://github.com/apache/superset/pull/30961#discussion_r1857350101


##########
superset/charts/post_processing.py:
##########
@@ -327,8 +329,11 @@ def apply_post_process(
         if query["result_format"] == ChartDataResultFormat.JSON:
             df = pd.DataFrame.from_dict(data)
         elif query["result_format"] == ChartDataResultFormat.CSV:
-            df = pd.read_csv(StringIO(data))
-
+            df = pd.read_csv(StringIO(data), 
+                             sep=csv_export_settings.get('sep', ','), 
+                             encoding=csv_export_settings.get('encoding', 
'utf-8'), 
+                             decimal=csv_export_settings.get('decimal', '.'))
+            

Review Comment:
   ```suggestion
               df = pd.read_csv(StringIO(data),
                                sep=csv_export_settings.get('sep', ','),
                                encoding=csv_export_settings.get('encoding', 
'utf-8'),
                                decimal=csv_export_settings.get('decimal', '.'))
               
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Reply via email to